Skip to content

feat: add C implementation for stats/base/dists/poisson/median #4018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 5, 2025
Merged

feat: add C implementation for stats/base/dists/poisson/median #4018

merged 10 commits into from
May 5, 2025

Conversation

@manvith2003
Copy link
Contributor

@manvith2003 manvith2003 commented Dec 18, 2024 •
edited
Loading

Resolves #3790

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for @stdlib/stats/base/dists/poisson/median along with relevant tests, benchmarks and examples

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 18, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 18, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/poisson/median $\color{green}165/165$
$\color{green}+100.00\%$ 		$\color{green}10/10$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}165/165$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter changed the title feat: add C implementation for stats/base/dists/poisson/median feat: add C implementation for stats/base/dists/poisson/median Dec 20, 2024
@Planeshifter Planeshifter added the bot: Update Copyright Years Pull request needing the copyright years of its files updated. label May 5, 2025
@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: Update Copyright Years Pull request needing the copyright years of its files updated. labels May 5, 2025
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label May 5, 2025
@Planeshifter Planeshifter removed the bot: In Progress Pull request is currently awaiting automation. label May 5, 2025
@Planeshifter
chore: apply suggestions from code review
694c906 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
docs: remove extra s and comment
63c5680 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
Merge branch 'develop' into poisson_median
7087540 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter previously approved these changes May 5, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge once all CI checks are green.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label May 5, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label May 5, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/poisson/median`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4018
Closes: https://github.com/stdlib-js/stdlib/issues/3790

Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: stdlib-bot <noreply@stdlib.io>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter
chore: add double quote back
557bffb 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter previously approved these changes May 5, 2025
View reviewed changes
@Planeshifter
style: fix indentation
2f6d6b0 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
style: fix indentation
7ddb912 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
style: fix indentation
edcee20 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter Planeshifter merged commit ad92859 into stdlib-js:develop May 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/poisson/median

3 participants

@manvith2003 @stdlib-bot @Planeshifter